Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: 7634 rename attributekeypacketdatahex in 04 channel v2 #7635

Conversation

gjermundgaraba
Copy link
Contributor

Description

closes: #7634

Relevant for relayer work @srdtrk since I also changed the attribute strings.


Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

  • Targeted PR against the correct branch (see CONTRIBUTING.md).
  • Linked to GitHub issue with discussion and accepted design, OR link to spec that describes this work.
  • Code follows the module structure standards and Go style guide.
  • Wrote unit and integration tests.
  • Updated relevant documentation (docs/).
  • Added relevant godoc comments.
  • Provide a conventional commit message to follow the repository standards.
  • Include a descriptive changelog entry when appropriate. This may be left to the discretion of the PR reviewers. (e.g. chores should be omitted from changelog)
  • Re-reviewed Files changed in the GitHub PR explorer.
  • Review SonarCloud Report in the comment section below once CI passes.

Copy link

sonarcloud bot commented Dec 7, 2024

Quality Gate Failed Quality Gate failed for 'ibc-go'

Failed conditions
66.0% Coverage on New Code (required ≥ 80%)

See analysis details on SonarQube Cloud

@gjermundgaraba gjermundgaraba merged commit 945b018 into feat/ibc-eureka Dec 9, 2024
65 of 66 checks passed
@gjermundgaraba gjermundgaraba deleted the gjermund/7634-rename-attributekeypacketdatahex-in-04-channel-v2 branch December 9, 2024 14:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants